Adjust kernel_module_disabled/missing_blacklist.fail.sh
#12898
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The might some default config that disables a kernel module. To ensure we're testing this correctly remove the "blacklist" line from all .conf files under /etc/modprobe.d/*.conf.
|
Code Climate has analyzed commit f5c6ed6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
This change has fixed the failing test scenario missing_blacklist.fail.sh for me.
jcerny@fedora:~/work/git/scap-security-guide (pr/12898)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel10 kernel_module_sctp_disabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-01-27-0927/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_kernel_module_sctp_disabled
INFO - Script wrong_value.fail.sh using profile (all) OK
INFO - Script empty.fail.sh using profile (all) OK
INFO - Script correct_value_modules_load_d.pass.sh using profile (all) OK
INFO - Script correct_value_run_modules_load_d.pass.sh using profile (all) OK
INFO - Script file_not_there.fail.sh using profile (all) OK
INFO - Script correct_value_run_modprobe_d.pass.sh using profile (all) OK
INFO - Script correct_value_modprobe_d.pass.sh using profile (all) OK
INFO - Script correct_value_usr_lib_modprobe_d.pass.sh using profile (all) OK
INFO - Script correct_value_usr_lib_modules_load_d.pass.sh using profile (all) OK
INFO - Script comment.fail.sh using profile (all) OK
INFO - Script missing_blacklist.fail.sh using profile (all) OK
jcerny@fedora:~/work/git/scap-security-guide (pr/12898)$ python3 tests/automatus.py rule --libvirt qemu:///system ssgts_rhel10 kernel_module_can_disabled
Setting console output to log level INFO
INFO - The base image option has not been specified, choosing libvirt-based test environment.
INFO - Logging into /home/jcerny/work/git/scap-security-guide/logs/rule-custom-2025-01-27-0931/test_suite.log
INFO - xccdf_org.ssgproject.content_rule_kernel_module_can_disabled
INFO - Script correct_value_usr_lib_modprobe_d.pass.sh using profile (all) OK
INFO - Script correct_value_modprobe_d.pass.sh using profile (all) OK
INFO - Script correct_value_usr_lib_modules_load_d.pass.sh using profile (all) OK
INFO - Script missing_blacklist.fail.sh using profile (all) OK
INFO - Script correct_value_run_modules_load_d.pass.sh using profile (all) OK
INFO - Script comment.fail.sh using profile (all) OK
INFO - Script correct_value_run_modprobe_d.pass.sh using profile (all) OK
INFO - Script wrong_value.fail.sh using profile (all) OK
INFO - Script file_not_there.fail.sh using profile (all) OK
INFO - Script empty.fail.sh using profile (all) OK
INFO - Script correct_value_modules_load_d.pass.sh using profile (all) OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The might some default config that disables a kernel module. To ensure we're testing this correctly remove the "blacklist" line from all
.conffiles under/etc/modprobe.d/*.conf.Rationale:
Fixes #12877
Review Hints:
Run the Automatus tests for
kernel_module_sctp_disabled(the one failing in the linked issue) and then some other module likekernel_module_can_disabled.